On Thu, Jul 31, 2008 at 04:34:03AM +0100, TJ wrote:
> This patch fails to achieve the intended aim since the values assigned
> to audio-*-list are hard-reset in several places in qemu/configure, both
> for initial variable 'declaration' and when setting sane defaults in the
> absence of command-line over-rides.
Not really sure which patch you are referring to as there is none on this
email, but the one I sent originally in this thread with this subject and
that I got back from the list and that is in the mail archive seem to work
correctly as shown below :
kvm-72 $ ./configure | grep Audio
Audio drivers oss
kvm-72 $ ./configure --audio-drv-list="alsa" | grep Audio
Audio drivers alsa
kvm-72 $ ./configure --audio-drv-list="sdl oss alsa" | grep Audio
Audio drivers sdl oss alsa
in case your copy got somehow mangled I am sending it again attached so it
will be easier to apply by doing something like :
$ tar -xzf kvm-72.tar.gz
$ cd kvm-72
$ patch -p1 < kvm-72-configure-audio-list.patch
Carlo
>From 0e457bd68805df64b120a70c44fd62860b759f3c Mon Sep 17 00:00:00 2001
From: Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]>
Date: Tue, 15 Jul 2008 22:52:42 -0700
Subject: [PATCH 2/2] configure: passthrough for audio-{drv,card}-list and logic
cleanup
Avoids reformatting for the options that are send verbatim to qemu's
configure and add a passthrough for qemu options that use a space
separated list of options like the list for audio drivers enabled
or the list for audio devices emulated.
Signed-off-by: Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]>
---
configure | 17 +++++++++++++----
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/configure b/configure
index 2558e0e..fc05767 100755
--- a/configure
+++ b/configure
@@ -10,6 +10,8 @@ qemu_cflags=
qemu_ldflags=
qemu_opts=
cross_prefix=
+audio_drv_list=
+audio_card_list=
arch=`uname -m`
target_exec=
@@ -39,7 +41,8 @@ EOF
}
while [[ "$1" = -* ]]; do
- opt="$1"; shift
+ optorig="$1"; shift
+ opt="$optorig"
arg=
if [[ "$opt" = *=* ]]; then
arg="${opt#*=}"
@@ -67,16 +70,21 @@ while [[ "$1" = -* ]]; do
--cross-prefix)
cross_prefix="$arg"
;;
+ --audio-drv-list)
+ audio_drv_list="$arg"
+ ;;
+ --audio-card-list)
+ audio_card_list="$arg"
+ ;;
--help)
usage
;;
*)
- qemu_opts="$qemu_opts $opt"
+ qemu_opts="$qemu_opts $optorig"
;;
esac
done
-
#set kenel directory
libkvm_kerneldir=$(readlink -f kernel)
@@ -114,11 +122,12 @@ fi
--extra-ldflags="-L $PWD/../libkvm $qemu_ldflags" \
--kernel-path="$libkvm_kerneldir" \
--prefix="$prefix" \
+ ${audio_drv_list:+"--audio-drv-list=$audio_drv_list"} \
+ ${audio_card_list:+"--audio-card-list=$audio_card_list"} \
${cross_prefix:+"--cross-prefix=$cross_prefix"} \
${cross_prefix:+"--cpu=$arch"} $qemu_opts
) || usage
-
cat <<EOF > config.mak
ARCH=$arch
PREFIX=$prefix
--
1.5.4.5
