On Tue, Aug 19, 2008 at 1:17 AM, Mohammed Gamal <[EMAIL PROTECTED]> wrote: > emulate_grp45() always returns 0. Therefore there is no need to check > its return value. > > Signed-off-by: Mohammed Gamal <[EMAIL PROTECTED]> > --- > arch/x86/kvm/x86_emulate.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c > index b97e80e..3aa9acb 100644 > --- a/arch/x86/kvm/x86_emulate.c > +++ b/arch/x86/kvm/x86_emulate.c > @@ -1810,9 +1810,7 @@ special_insn: > c->dst.type = OP_NONE; /* Disable writeback. */ > break; > case 0xfe ... 0xff: /* Grp4/Grp5 */ > - rc = emulate_grp45(ctxt, ops); > - if (rc != 0) > - goto done; > + emulate_grp45(ctxt, ops); > break; > } > > -- > 1.5.4.3 > > >
Ignore this patch, it'd be wiser to keep the check when we add the rest of Grp4/5 instructions to emulate_grp45() -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
