Marcelo Tosatti wrote: > On Sun, Aug 17, 2008 at 10:41:07AM +0300, Avi Kivity wrote: > >> Avi Kivity wrote: >> >>> Marcelo Tosatti wrote: >>> >>>> KVM: x86: do not execute halted vcpus >>>> >>>> Alright, need_resched was actually checked in vcpu_enter_guest, so this >>>> checks signal_pending too: >>>> >>>> Offline or uninitialized vcpu's can be executed if requested to perform >>>> userspace work. >>>> Follow Avi's suggestion to handle halted vcpu's in the main loop, >>>> simplifying kvm_emulate_halt(). Introduce a new vcpu->requests bit to >>>> indicate events that promote state from halted to running. >>>> >>>> Also standardize vcpu wake sites. >>>> >>>> >>> Applied, thanks. >>> >>> >> This killed reboot, so I reverted it. >> > > Works for me (both UP/SMP, Windows/Linux, guest initiated/system_reset), > and can't find anything obvious in the diff. > > How can it be reproduced? > >
Windows UP guest initiated. Since you say it worked, I probably botched something while testing. I'll try again. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
