On Thu, Aug 28, 2008 at 7:05 PM, Avi Kivity <[EMAIL PROTECTED]> wrote:
> Mohammed Gamal wrote:
>> Consolidate mov r, imm testing in one function
>>
>>
>
> Doesn't apply, likely due to coding style fixes I made to the previous
> patch.
>
>> - if(!regs_equal(&inregs, &outregs, R_AX) || outregs.eax != 1234567890)
>> + if(!regs_equal(inregs, outregs, R_AX) || outregs->eax != 1234567890)
>>
>
> "if _nospace_ (" hurts my eyes. I find it really confusing. Please
> avoid it.
>
Grrr... why do I keep forgetting that! Sorry. Will fix and resend.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
