On Sep 1, 2008, at 4:25 PM, Avi Kivity wrote:
Alexander Graf wrote:
+
+ u32 hflags;
};
bool gif : 1;
(or even
bool gif;)?
It's not visible in the patches I sent, but I did use the hflags
for a VMLOAD+VMRUN+VMSAVE aggregation hack. It's still somewhat
flacky wrt save/restore though, so I didn't send it. Hflags might
be useful nevertheless though.
You mean code patching?
Yes.
Need save/restore support as well. Can be in a different patch,
though.
It might be a good idea to share hflags with qemu. I implemented
the GIF there already.
Nothing prevents a similar format, though of course qemu is free to
evolve, and anything in the kvm userspace interface is cast in stone.
For the userspace interface, a __u32 is better than a bool and
certainly better than bitfields. I was only suggesting bool for the
internal representation.
How exactly would you like to see the userspace bridge implemented? I
thought it might be good to put hflags in the x86 arch struct and just
have it transferred in get_sregs and set_sregs. I don't know if I
break any old userspace doing that though...
Alex
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
