Re: [PATCH][REPOST] KVM: VMX: Always return 0 for clear_flush_young() when using EPT

[Avi Kivity]

Yang, Sheng wrote:

Hi Avi

It seems something wrong with my git-send-email, and I can't got my post from kvm@vger.kernel.org, so resend it. Sorry for inconvenient.

-               _young = _spte & PT_ACCESSED_MASK;
-               if (_young) {
-                       young = 1;
-                       clear_bit(PT_ACCESSED_SHIFT, (unsigned long *)spte);
+
+               /* always return old for EPT */
+               if (!shadow_accessed_mask)
+                       _young = 0;
+               else {
+                       _young = _spte & PT_ACCESSED_MASK;
+                       if (_young) {
+                               young = 1;
+                               clear_bit(PT_ACCESSED_SHIFT,
+                                         (unsigned long *)spte);
+                       }


Why not to a

 if (!shadow_access_mask)
      return 0;

in the beginning?

I guess returning 'old' is safer than returning 'young'.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html