Re: [PATCH 2/2] KVM: Device Assignment with VT-d

[Amit Shah]

* On Tuesday 09 September 2008 19:21:20 Han, Weidong wrote:

> +static int kvm_iommu_map_memslots(struct kvm *kvm)
> +{
> +     int i, rc;
> +
> +     down_read(&kvm->slots_lock);
> +     for (i = 0; i < kvm->nmemslots; i++) {
> +             rc = kvm_iommu_map_pages(kvm, kvm->memslots[i].base_gfn,
> +                                      kvm->memslots[i].npages);
> +             if (rc) {
> +                     up_read(&kvm->slots_lock);
> +                     return rc;
> +             }
> +     }
> +     up_read(&kvm->slots_lock);
> +     return 0;
> +}

I simplified this to:

static int kvm_iommu_map_memslots(struct kvm *kvm)
{
        int i, r;

        down_read(&kvm->slots_lock);
        for (i = 0; i < kvm->nmemslots; i++) {
                r = kvm_iommu_map_pages(kvm, kvm->memslots[i].base_gfn,
                                        kvm->memslots[i].npages);
                if (r)
                        break;
        }
        up_read(&kvm->slots_lock);
        return r;
}

Also cleaned up some whitespace.

I'll send out the patchset soon.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html