On Fri, Sep 12, 2008 at 10:40 AM, Guillaume Thouvenin
<[EMAIL PROTECTED]> wrote:
> On Tue, 09 Sep 2008 17:51:03 +0300
> Avi Kivity <[EMAIL PROTECTED]> wrote:
>
>> Guillaume Thouvenin wrote:
>> > - case 0x38 ... 0x3d:
>> > + case 0x38 ... 0x3b:
>> > cmp: /* cmp */
>> > emulate_2op_SrcV("cmp", c->src, c->dst, ctxt->eflags);
>> > break;
>> > + case 0x3c ... 0x3d: /* cmp al imm8 or ax imm16 or eax imm32 */
>> > + c->dst.type = OP_REG;
>> > + c->dst.bytes = c->op_bytes;
>> > + c->dst.ptr = &c->regs[VCPU_REGS_RAX];
>> > + if (c->op_bytes == 1)
>> > + c->dst.val = *(u8 *)c->dst.ptr;
>> > + else if (c->op_bytes == 2)
>> > + c->dst.val = *(u16 *)c->dst.ptr;
>> > + else
>> > + c->dst.val = *(u32 *)c->dst.ptr;
>> > + c->dst.orig_val = c->dst.val;
>> > + goto cmp;
>> >
>>
>> SrcAcc would remove the need for this change.
>
> As I don't see SrcAcc in the source it means that you suggest to add a
> new type of source operand right?
>
> Guillaume
>
Yes
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html