Hello Weidong, ----- "Weidong Han" <[EMAIL PROTECTED]> wrote:
> Amit, > > There are a few format issues in your patch, and this patch doesn't > work. > > Flag KVM_DEV_ASSIGN_ENABLE_IOMMU is not set correctly. My comment > inline. > > +#ifdef KVM_CAP_IOMMU > > + /* We always enable the IOMMU if present > > + * (or when not disabled on the command line) > > + */ > > + r = kvm_check_extension(kvm_context, KVM_CAP_IOMMU); > > + if (r && !disable_iommu) > > + assigned_devices[nr_assigned_devices].dma |= > > + KVM_DEV_ASSIGN_ENABLE_IOMMU; > > should add assigned_dev_data.flags |= KVM_DEV_ASSIGN_ENABLE_IOMMU > here, > otherwise following kvm_assign_pci_device() won't assign device with > iommu. Correct. I'll update this. BTW, I might get a VT-d machine soon so that I can start testing VT-d. > In addtion, I think we should add following lines to > kernel/x86/Kbuild: > > ifeq ($(CONFIG_DMAR),y) > kvm-objs += vtd.o > endif > > otherwise, "modprobe kvm" after making userspace. Yes, the userspace needs a way to compile the vtd module. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
