Sheng Yang wrote:
Derived from Avi's suggestion, now every call of kvm_set_irq() should offer
a irq_source_id, which is allocated by kvm_allocate_irq_sources(). We based
on irq_source_id to identify irq source and implement logical OR for shared
level interrupts.
The allocated irq_source_id can be freed by kvm_free_irq_sources().
+
+ u32 irq_sources_bitmap;
+ u32 irq_states[KVM_IOAPIC_NUM_PINS];
You're using the bit manipulation functions on this, which use unsigned
long parameters. This will generate unaligned accesses, which will
probably annoy ia64 when this code is ported. So it may be better to
wast some space and use unsigned longs here.
Other than that, looks a nice and clean to me.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
