Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> Avi Kivity wrote:
>> 
>>> Zhang, Xiantao wrote:
>>> 
>>>> +
>>>> +/* This should be called with the kvm->lock mutex held */
>>>> +void kvm_set_irq(struct kvm *kvm, int irq, int level) +{
>>>> +  /* Not possible to detect if the guest uses the PIC or the
>>>> +   * IOAPIC.  So set the bit in both. The guest will ignore
>>>> +   * writes to the unused one.
>>>> +   */
>>>> +  kvm_ioapic_set_irq(kvm->arch.vioapic, irq, level); +#ifdef X86
>>>> +  kvm_pic_set_irq(pic_irqchip(kvm), irq, level);
>>>> +#endif
>>>> +}
>>>> 
>>>> 
>>> Will non-x86, non-ia64 archs survive this?
>>> 
>> So far, I only see x86 and ia64 can share this code, since it is
>> splitted from x86 arch.  Currenlty non-x86 and non-ia64 archs
>> shouldn't compile in this part. 
>> 
> 
> Right.  Does the patch actually ensure this?

Yes, other archs except x86 and ia64 can't reach the code, because they
didn't compile irq_comm.c 
Xiantao
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to