Sheng Yang wrote: > On Wednesday 08 October 2008 16:48:11 Zhang, Xiantao wrote: >> Hi, Sheng >> Since these macros are just used by kvm, and considering >> cross-arch support, could you move these stuff to >> include/linux/kvm_host.h ? So they can be shared for x86 and ia64. >> Thanks >> Xiantao > > I don't think so... The problem is, we can't assume that IA64 and x86 > use same MSI format, and I think we shouldn't do that. And this patch > just modify x86 host linux side. So if they can be shared, host > kernel side should also share them, then this file(msidef.h) > shouldn't put on include/asm-x86/... So for now, probably it's more > reasonable to keep it here. You know, device-assigment logic should be shared by x86 and ia64 (so far), so we should make these code arch-indpendent, other than duplicate the work for ia64 side. So maybe you should guarantee it also work on ia64 side before pushing them into upstream.:) I am not familiar with the detail about the format of MSI in x86 and ia64 side, but anyway they should only have a small gap at the most. Thanks Xiantao
>> Sheng Yang wrote: >>> Signed-off-by: Sheng Yang <[EMAIL PROTECTED]> >>> --- >>> include/asm-x86/msidef.h | 3 +++ >>> 1 files changed, 3 insertions(+), 0 deletions(-) >>> >>> diff --git a/include/asm-x86/msidef.h b/include/asm-x86/msidef.h >>> index 296f29c..fdeebbb 100644 --- a/include/asm-x86/msidef.h >>> +++ b/include/asm-x86/msidef.h >>> @@ -15,8 +15,11 @@ >>> MSI_DATA_VECTOR_MASK) >>> >>> #define MSI_DATA_DELIVERY_MODE_SHIFT 8 >>> +#define MSI_DATA_DELIVERY_MODE_MASK 0x700 >>> #define MSI_DATA_DELIVERY_FIXED (0 << >> >> MSI_DATA_DELIVERY_MODE_SHIFT) >> >>> #define MSI_DATA_DELIVERY_LOWPRI (1 << >> >> MSI_DATA_DELIVERY_MODE_SHIFT) >> >>> +#define MSI_DATA_DELIVERY_FIXED_VAL 0 >>> +#define MSI_DATA_DELIVERY_LOWPRI_VAL 1 >>> >>> #define MSI_DATA_LEVEL_SHIFT 14 >>> #define MSI_DATA_LEVEL_DEASSERT (0 << >> >> MSI_DATA_LEVEL_SHIFT) >> >>> -- >>> 1.5.4.5 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
