On Thu, 09 Oct 2008 11:06:50 +0200
Avi Kivity <[EMAIL PROTECTED]> wrote:
>
> The regular shift instructions (shl, rcl, etc) come in three varieties:
> shift by 1, shift by imm8, and shift by CL. Right now they use
> SrcImmByte and decode the implied '1' and CL by hand. If we change them
> to use Src2, they can reuse the Src2CL and Src2One support that you are
> adding now.
Ok I see but shld, rcld, etc come only in two varieties: immediate and
CL. So maybe it could be better to replace SrcImplicit (that is not
really useful) by SrcOne? and then we will have
...
case SrcOne:
c->src.val = 1;
break;
...
and we can reuse Src2CL as well.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
