Alexander Graf wrote:
};
+#define HF_GIF_MASK (1 << 0)
+
Why not use bool for gif? It will improve code readability.
This way the code is closer to what qemu cpu emulation is doing
(probably no good reason). Also it allows for more flags to be added
later on. I originally had a VMLOAD/VMRUN/VMSAVE merging hack, that
would set the hflag - until I realized that it's not SMP safe.
Well, bool is also extensible (add more bools...).
Nevertheless, I thought it might be better to have something that's
easily extensible. If you think otherwise, I'd change it, but I like
the hflags idea in general.
It's a matter of personal preference; I guess it would be silly for me
to insist on such a small point given the massive amount of work that
has gone into this. So I'll leave it up to you.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
