Avi Kivity wrote:

+8) Merge in additional changes in kvm-userspace tree

One of the important changes is running with signal delivery disabled, since that's particularly slow (requires save/restore of the floating point state, for example).

I think we need the IO thread first.  We're slowly getting there

+
+typedef struct kvm_userspace_memory_region KVMSlot;

KVMMemorySlot?

Sure.

+
+static KVMState *kvm_state;

Why a pointer?

I would like to avoid having the global state to begin with.

+    if (ret < 0) {
+        dprintf("kvm_create_vcpu failed\n");

showing errno would be nice.

Indeed.

+
+static void kvm_getput_reg(__u64 *kvm_reg, target_ulong *qemu_reg, int set)
+{
+    if (set)
+        *kvm_reg = *qemu_reg;
+    else
+        *qemu_reg = *kvm_reg;
+}

Ugh.

I think live migration is now broken, since kvm accesses will not update the qemu dirty bitmap.

Eh?  I don't follow you here.

Regards,

Anthony Liguori
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to