On Tue, Nov 04, 2008 at 04:35:19PM +0200, Avi Kivity wrote:
> Sheng Yang wrote:
>>> In fact, it's not just for pci.  We could msi-enable e1000 and get   
>>> improved performance there as well.
>>>     
>>
>> E1000? Don't understand... Sounds like INTx->MSI...
>>   
>
> There are msi-capable e1000 cards.  If we upgrade qemu's e1000 to  
> support msi, and if the guest supports msi, it will be msi all the way.

Oh, forgot we got e1000 emulation in qemu...
>
>>>> But I guess what you means is only set
>>>> gsi can result in kvm_set_irq() deliver the MSI correctly. I think this can
>>>> be done. Associating gsi with guest_msi_addr and guest_msi_data in a linked
>>>> list, for gsi >= IOAPIC_PINS,
>>>>       
>>> Let's say, (gsi >> 24) == 1.  That gives us 16M potential MSIs.
>>>     
>>
>> Confused... GSI become a bitmap?
>>   
>
> A structure...
>
> struct gsi {
>    u32 n : 24;
>    u32 type : 8; // 0 -> classic gsi, 1 -> msi
> };

I just don't understand why we need 24 bits for n? GSI can be that wide?

--
regards
Yang, Sheng
>
>
> -- 
> error compiling committee.c: too many arguments to function
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to