On 04.11.2008, at 14:37, Avi Kivity wrote:
Alexander Graf wrote:
This should be done in x86.c and made to apply to svm as well.
Other VMMs would use efer.svme as an indication that svm is in
use, similar to cr4.vmxe today.
Right, that sounds good. So just track the usage counter in x86.c
and then split the hardware_{en,dis}able functions?
What's there to split in hardware_enable()?
enable allocates local vcpus and sets the vmx feature MSR, disable
clears the vcpus. But yeah, no need to split that.
Or do you want to actually call hardware_{en,dis}able on the usage
counter events?
Yes.
There is no real need to enable/disable everything just because of
the usage counter.
All it does is enable the feature, enable vmxe, and vmxon. I don't
think we gain anything by splitting it.
Ok. But I think this would change kvm_main.c, not x86.c, right? We'd
basically move hardware_enable and disable generically from the module
initialization to the vcpu creation. Could this break other
architectures?
Alex
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
