Amit Shah wrote: > * On Friday 07 Nov 2008 15:55:18 Zhang, Xiantao wrote: > >> --- a/qemu/vl.c >> +++ b/qemu/vl.c >> @@ -8694,7 +8694,7 @@ static void help(int exitcode) #endif >> "-no-kvm-irqchip disable KVM kernel mode PIC/IOAPIC/LAPIC\n" >> "-no-kvm-pit disable KVM kernel mode PIT\n" >> -#if defined(TARGET_I386) || defined(TARGET_X86_64) || >> defined(__linux__) +#if defined(TARGET_I386) || >> defined(TARGET_X86_64) || defined(TARGET_IA64) >>>> defined(__linux__) "-pcidevice > > It would be better to use #if defined (USE_KVM_DEVICE_ASSIGNMENT) > here (and in the rest of the file) instead of adding architectures to > this list as is done in the Makefile.
Agree. Good suggestion! And I just follow the original style, maybe needs a cleanup. Xiantao -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
