Guillaume Thouvenin wrote:
> On Tue, 11 Nov 2008 16:28:04 -0000
> Avi Kivity <[EMAIL PROTECTED]> wrote:
> 
> 
>> @@ -450,6 +454,10 @@ static void *ap_main_loop(void *_env)
>>      kvm_create_vcpu(kvm_context, env->cpu_index);
>>      kvm_qemu_init_env(env);
>> 
>> +    /* do ioperm for io ports of assigned devices */
>> +    LIST_FOREACH(data, &ioperm_head, entries)
>> +    on_vcpu(env, kvm_arch_do_ioperm, data);
>> +
>>      /* signal VCPU creation */
>>      pthread_mutex_lock(&qemu_mutex);
>>      vcpu->created = 1;
> 
> kvm_arch_do_ioperm() is defined if USE_KVM_DEVICE_ASSIGNMENT is
> defined. So this should be wrapped by:
> 
> #ifdef USE_KVM_DEVICE_ASSIGNMENT
>      /* do ioperm for io ports of assigned devices */
>      LIST_FOREACH(data, &ioperm_head, entries)
>         on_vcpu(env, kvm_arch_do_ioperm, data);
> #endif
> 
> no?

yes, it is better to wrap it.  Thanks.

Regards,
Weidong

> 
> Best regards,
> Guillaume

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to