Alexander Graf wrote:
> Muli Ben-Yehuda wrote:
>
>> On Fri, Nov 21, 2008 at 04:14:37PM +0100, Alexander Graf wrote:
>>
>>
>>
>>> +static int vmrun_interception(struct vcpu_svm *svm, struct kvm_run
>>> *kvm_run)
>>> +{
>>> + nsvm_printk("VMrun\n");
>>> + if (nested_svm_check_permissions(svm))
>>> + return 1;
>>> +
>>> + svm->next_rip = kvm_rip_read(&svm->vcpu) + 3;
>>> + skip_emulated_instruction(&svm->vcpu);
>>> +
>>> + if (nested_svm_do(svm, svm->vmcb->save.rax, 0,
>>> + NULL, nested_svm_vmrun))
>>> + return 1;
>>> +
>>> + if (nested_svm_do(svm, svm->vmcb->control.msrpm_base_pa, 0,
>>> + NULL, nested_svm_vmrun_msrpm))
>>> + return 1;
>>>
>>>
>> nested_svm_vmrun returns 1 unconditionally, so we never call
>> nested_svm_vmrun_msrpm.
>>
>>
>
> Wow the one thing you pointed out earlier. I must've missed to write
> that on my TODO list.
> I'll fix this right now :). Await v7 any second now.
>
Wow this is more tricky than I thought. I gotta go now, but I'll look
into it in more detail on Tuesday. I promise :-). For now please just
don't use the MSR check.
Alex
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
