On Sunday 23 November 2008 18:12:54 Avi Kivity wrote: > Sheng Yang wrote: > > Signed-off-by: Sheng Yang <[EMAIL PROTECTED]> > > --- > > arch/x86/include/asm/msidef.h | 4 ++-- > > arch/x86/kernel/io_apic.c | 4 ++-- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/arch/x86/include/asm/msidef.h > > b/arch/x86/include/asm/msidef.h index 6706b30..988cb27 100644 > > --- a/arch/x86/include/asm/msidef.h > > +++ b/arch/x86/include/asm/msidef.h > > @@ -15,8 +15,8 @@ > > MSI_DATA_VECTOR_MASK) > > > > #define MSI_DATA_DELIVERY_MODE_SHIFT 8 > > -#define MSI_DATA_DELIVERY_FIXED (0 << MSI_DATA_DELIVERY_MODE_SHIFT) > > -#define MSI_DATA_DELIVERY_LOWPRI (1 << MSI_DATA_DELIVERY_MODE_SHIFT) > > +#define MSI_DATA_DELIVERY_FIXED_BIT (0 << > > MSI_DATA_DELIVERY_MODE_SHIFT) > > +#define MSI_DATA_DELIVERY_LOWPRI_BIT (1 << > > MSI_DATA_DELIVERY_MODE_SHIFT) > > These are usually named _MASK, not _BIT. But I recommend dropping this > patch, it can only cause conflicts with other development.
Yeah, I also don't like this. It's easily cause chaos... I will compromise on it, use IOAPIC_LOWEST_PRIORITY and IOAPIC_FIXED for now, and drop the related two patches. -- regards Yang, Sheng -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
