On Fri, 05 Dec 2008 19:17:17 +0200
Avi Kivity <[EMAIL PROTECTED]> wrote:
> Guillaume Thouvenin wrote:
> > Add 'shld' instruction test in real mode test harness.
> >
> >
> Applied, thanks.
>
> > Avi, on my computer this test is broken but the problem seems to be
> > elsewhere because test_shld() works fine alone. I'm inspecting other
> > test. Used alone shld gives the right values (shift is ok and bits are
> > added).
> >
>
> I see a different failure, due to leakage of register values from one
> test to another. I fixed it up. If you see the failure after the fix,
> we can reexamine it.
>
Cool it works fine now. On the other hand eax and edx registers are
initialized twice now, once is enough ;)
Signed-off-by: Guillaume Thouvenin <[EMAIL PROTECTED]>
---
user/test/x86/realmode.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/user/test/x86/realmode.c b/user/test/x86/realmode.c
index dbe34b2..f6d5326 100644
--- a/user/test/x86/realmode.c
+++ b/user/test/x86/realmode.c
@@ -146,8 +146,6 @@ void test_shld(void)
struct regs inregs = { .eax = 0xbe, .edx = 0xef000000 }, outregs;
MK_INSN(shld_test, "shld $8,%edx,%eax\n\t");
- inregs.eax = 0xbe;
- inregs.edx = 0xef000000;
exec_in_big_real_mode(&inregs, &outregs,
insn_shld_test,
insn_shld_test_end - insn_shld_test);
--
1.6.0.4.623.g171d7
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
