[PATCH] kvm: qemu: device-assignment: really exit if cmdline parsing fails

[Mark McLoughlin]

On Fri, 2008-11-28 at 17:10 +0000, Mark McLoughlin wrote:
> It's standard practice in qemu to exit if command line parameter
> fails, so do that here too.
> 
> Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]>
> ---
>  qemu/hw/device-assignment.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
> index eb2a73a..8fbd66c 100644
> --- a/qemu/hw/device-assignment.c
> +++ b/qemu/hw/device-assignment.c
> @@ -620,6 +620,7 @@ void add_assigned_devices(PCIBus *bus, const char 
> **devices, int n_devices)
>          if (!adev) {
>              fprintf(stderr, "Could not add assigned device %s\n", 
> devices[i]);
>              continue;
> +            exit(1);

Um, that's a rather embarrassing thinko.

Cheers,
Mark.

From: Mark McLoughlin <[EMAIL PROTECTED]>
Subject: [PATCH] kvm: qemu: device-assignment: really exit if cmdline parsing 
fails

Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]>
---
 qemu/hw/device-assignment.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
index 4a38a22..7a66665 100644
--- a/qemu/hw/device-assignment.c
+++ b/qemu/hw/device-assignment.c
@@ -668,7 +668,6 @@ void add_assigned_devices(PCIBus *bus, const char 
**devices, int n_devices)
         adev = add_assigned_device(devices[i]);
         if (!adev) {
             fprintf(stderr, "Could not add assigned device %s\n", devices[i]);
-            continue;
             exit(1);
         }
 
-- 
1.5.4.3

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html