On Tuesday 30 December 2008 18:41:54 Avi Kivity wrote: > Sheng Yang wrote: > >>> MASK_MSIX, and UNMASK, every two action are in pairs but we have to use > >>> twice bits to store them. So I'd like to use MSI_ACTION approach... > >> > >> Well, it you have flags without ENABLE_MSI, doesn't it imply > >> DISABLE_MSI? > >> > >> The structure contains the state we want to reach, not a command we wish > >> the kernel to perform. > > > > Yes, that's what I want. But check more than one flags(for MSI-X) to > > determine where to go is not that clear. So I add a flag here to indicate > > the operation type which I think is a little more clear. > > Don't understand. Do you mean MSI and MSI-X are mutually exclusive? > > If so, we can add a comment.
Yes, MSI/MSI-X are mutually exclusive. OK, I will try to keep this, just hope the logic of code won't become too complicate.. -- regards Yang, Sheng -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
