Sheng Yang wrote:
On Monday 05 January 2009 00:14:44 Avi Kivity wrote:
Allow clients to request notifications when the guest masks or unmasks a
particular irq line.  This complements irq ack notifications, as the guest
will not ack an irq line that is masked.

Currently implemented for the ioapic only.

Hi Avi

Need a lock for this list? Seems kvm_fire_mask_notifiers() implicit holding kvm->lock, but register/unregister didn't. And I think we need some comments for the necessary of lock.

Good catch. Everything in struct kvm is protected by kvm->lock (except vcpus and the mmu... need a locking document). I added locking around PIT creation so now registration is also protected (it also fixes a potential leak if two threads try to create a PIT simultaneously).

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to