On Thursday 08 January 2009 04:36:02 Alex Williamson wrote:
> virtio_net: Enable setting MAC, promisc, and allmulti mode
Hi Alex,
There's nothing wrong with this idea: I assume you have an actual usage
for this rather than it being an abstract improvement?
> @@ -41,7 +41,14 @@ struct virtnet_info
> struct virtqueue *rvq, *svq;
> struct net_device *dev;
> struct napi_struct napi;
> - unsigned int status;
> + union {
> + u16 raw;
> + struct {
> + u16 link:1;
> + u16 promisc:1;
> + u16 allmulti:1;
> + } bits;
> + } status;
I don't think this works, as it depends on bitfield endian.
> @@ -30,7 +32,14 @@ struct virtio_net_config
> __u8 mac[6];
> /* Status supplied by host; see VIRTIO_NET_F_STATUS and VIRTIO_NET_S_*
> * bits above */
> - __u16 status;
> + union {
> + __u16 raw;
> + struct {
> + __u16 link:1;
> + __u16 promisc:1;
> + __u16 allmulti:1;
> + } bits;
> + } status;
> } __attribute__((packed));
As does this. I think we need to leave the status bitfield as is.
Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
