On 25/03/14 14:56, Paolo Bonzini wrote:
> Il 25/03/2014 14:35, Christian Borntraeger ha scritto:
>> + spin_lock_bh(&li->lock);
>> + list_for_each_entry_safe(inti, n, &li->list, list) {
>> + list_del(&inti->list);
>> + kfree(inti);
>> + }
>> + atomic_set(&li->active, 0);
>> + spin_unlock_bh(&li->lock);
>> +}
>
> Out of curiosity, why the _bh?
Probably just copied from all other accesses. We normally protect against the
hrtimer
wakeup bottom half(see kvm_s390_tasklet). For normal guests/userspace this
should not
happen, (after all we are resetting the CPU only on startup or during reset
when the vCPUS
are nor running) but the KVM interface allows to trigger this while the CPU is
waiting
for a timer.
In fact I think your question just made me realize that this code needs some
more
fixes, e.g. resetting the timer on initial reset and getting the CPU out of
wait.
Will investigate.
Christian
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
