From: Dan Carpenter <[email protected]>

When copy_from_user() fails, this code returns the number of bytes
remaining instead of a negative error code.  The positive number is
returned to the user but otherwise it is harmless.

Signed-off-by: Dan Carpenter <[email protected]>
Signed-off-by: Christian Borntraeger <[email protected]>
---
 arch/s390/kvm/guestdbg.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/s390/kvm/guestdbg.c b/arch/s390/kvm/guestdbg.c
index 757ccef..3e8d409 100644
--- a/arch/s390/kvm/guestdbg.c
+++ b/arch/s390/kvm/guestdbg.c
@@ -223,9 +223,10 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu,
                goto error;
        }
 
-       ret = copy_from_user(bp_data, dbg->arch.hw_bp, size);
-       if (ret)
+       if (copy_from_user(bp_data, dbg->arch.hw_bp, size)) {
+               ret = -EFAULT;
                goto error;
+       }
 
        for (i = 0; i < dbg->arch.nr_hw_bp; i++) {
                switch (bp_data[i].type) {
-- 
1.8.4.2

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to