Hi Alex,
Just had a quick looked over these and they seem pretty good, but some
broad comments:
- The logic around "is this a NIC+TAP pair?" would be good to have a
better API around. We need this to merge virtio GSO support too.
Anthony had some ideas here.
- I think you could keep the client_added()/removed() logic in net.c
and things would be a lot cleaner. I think you just want to trigger
a reload of the filter, right? So a "reload this filter" callback
to qemu_vlan_rxfilter() might do it.
- What do we need rxfilter=on|off on the command line for?
Cheers,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
