On Thu, Feb 12, 2009 at 06:07:48PM +0800, Sheng Yang wrote:
> Introduce KVM_SET_MSIX_NR and KVM_SET_MSIX_ENTRY two ioctls.
> 
> This two ioctls are used by userspace to specific guest device MSI-X entry
> number and correlate MSI-X entry with GSI during the initialization stage.
> 
> MSI-X should be well initialzed before enabling.
> 
> Don't support change MSI-X entry number for now.
> 
> Signed-off-by: Sheng Yang <[email protected]>

> +             adev->host_msix_entries = kzalloc(sizeof(struct msix_entry) *
> +                                             entry_nr->entry_nr,
> +                                             GFP_KERNEL);

> +             if (!adev->host_msix_entries) {

Please verify its within a sane limit. Like the msr entry ioctl code.
Also free host_msix_entries if guest_msix_entries allocation fails.

Otherwise seems OK.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to