2014-08-20 09:47+0200, Christian Borntraeger:
> On 19/08/14 22:35, Radim Krčmář wrote:
> 
> > --- a/virt/kvm/kvm_main.c
> > +++ b/virt/kvm/kvm_main.c
> > @@ -3123,6 +3123,8 @@ static void kvm_sched_in(struct preempt_notifier *pn, 
> > int cpu)
> >     if (vcpu->preempted)
> >             vcpu->preempted = false;
> > 
> > +   kvm_arch_sched_in(vcpu, cpu);
> > +
> >     kvm_arch_vcpu_load(vcpu, cpu);
> >  }
> > 
> 
> Why cant you reuse kvm_arch_vcpu_load? Its also called on each sched_in and 
> is architecture specific.

kvm_arch_vcpu_load is also called from kvm_vcpu_ioctl, so we'd be
shrinking unnecessarily.
(sched_in gives us a bit of useful information about the state of the
 system, kvm_vcpu_ioctl not that much.)
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to