Both the 16550/8250 UART emulation in kvmtool as well as all the
drivers and DTBs for real hardware use level triggered interrutpts.
But the device tree currently describes them as being edge triggered,
which can lead to hangs in guests.
Use the new IRQ type parameter to properly describe the interrupts.
This goes along the lines of a similar QEMU patch:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=0be969a2d974971628fc4ed95834d22ecf0fd497

Signed-off-by: Andre Przywara <andre.przyw...@arm.com>
---
 tools/kvm/hw/serial.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/kvm/hw/serial.c b/tools/kvm/hw/serial.c
index 37bcd28..8814afe 100644
--- a/tools/kvm/hw/serial.c
+++ b/tools/kvm/hw/serial.c
@@ -385,7 +385,7 @@ static void serial8250_generate_fdt_node(struct ioport 
*ioport, void *fdt,
        _FDT(fdt_begin_node(fdt, dev_name));
        _FDT(fdt_property_string(fdt, "compatible", "ns16550a"));
        _FDT(fdt_property(fdt, "reg", reg_prop, sizeof(reg_prop)));
-       generate_irq_prop(fdt, dev->irq, IRQ_TYPE_EDGE_RISING);
+       generate_irq_prop(fdt, dev->irq, IRQ_TYPE_LEVEL_HIGH);
        _FDT(fdt_property_cell(fdt, "clock-frequency", 1843200));
        _FDT(fdt_end_node(fdt));
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to