> -----Original Message----- > From: David Woodhouse [mailto:dw...@infradead.org] > Sent: Wednesday, January 28, 2015 11:23 PM > To: Wu, Feng > Cc: t...@linutronix.de; mi...@redhat.com; h...@zytor.com; x...@kernel.org; > g...@kernel.org; pbonz...@redhat.com; j...@8bytes.org; > alex.william...@redhat.com; jiang....@linux.intel.com; eric.au...@linaro.org; > linux-ker...@vger.kernel.org; io...@lists.linux-foundation.org; > kvm@vger.kernel.org > Subject: Re: [v3 02/26] iommu: Add new member capability to struct > irq_remap_ops > > On Fri, 2014-12-12 at 23:14 +0800, Feng Wu wrote: > > This patch adds a new member capability to struct irq_remap_ops, > > this new function ops can be used to check whether some > > features are supported, such as VT-d Posted-Interrupts. > > > + /* Check some capability is supported */ > > + bool (*capability)(enum irq_remap_cap); > > + > > Does this need to be a function call? Or could we just have a set of > flags in the irq_remap_ops instead, with less overhead to check them?
Sounds a good idea, I will follow this in the next post! Thanks for the comments! Thanks, Feng > > -- > David Woodhouse Open Source Technology > Centre > david.woodho...@intel.com Intel > Corporation
