On Thu, Mar 19, 2015 at 09:52:41PM +0100, Radim Krčmář wrote: > An overhead from function call is not appropriate for its size and > frequency of execution. > > Suggested-by: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Radim Krčmář <rkrc...@redhat.com> > --- > I'm not very fond of that smp_rmb(): there is no real synchronization > against update_handled_vectors(),
Yes, because the guest OS should provide synchronization (it should shutdown interrupts before attempting to modify IOAPIC table). The smp_wmb is necessary. > so the only point I see is to drop > cached value of handled_vectors, which seems like bad use of LFENCE. test_bit has volatile on *addr, so don't see why the smp_rmb is necessary at all. Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
