On Mon, Mar 16, 2009 at 10:34:01PM +0200, Gleb Natapov wrote: > > Doesnt the vm shutdown path rely on the while loop you removed to free > > all shadow pages before freeing the mmu kmem caches, if mmu notifiers > > is disabled? > > > Shouldn't mmu_free_roots() on all vcpus clear all mmu pages?
No. It only zaps the present root on every vcpu, but not the children. > > And how harmful is that loop? Zaps the entire cache on cpu hotunplug? > > > KVM doesn't support vcpu destruction, but destruction is called anyway > on various error conditions. The one that easy to trigger is to create > vcpu with the same id simultaneously from two threads. The result is > OOPs in random places. mmu_lock should be held there, and apparently it is not. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
