Re: [PATCH 8/9] KVM: VMX: introduce set_clear_2nd_exec_ctrl()

[Xiao Guangrong]

On 09/07/2015 07:27 PM, Paolo Bonzini wrote:

On 21/08/2015 06:50, Xiao Guangrong wrote:

+static void set_clear_2nd_exec_ctrl(u32 ctrls, bool set)
+{
+       u32 exec_ctrl = vmcs_read32(SECONDARY_VM_EXEC_CONTROL);
+
+       if (set)
+               exec_ctrl |= ctrls;
+       else
+               exec_ctrl &= ~ctrls;
+
+       vmcs_write32(SECONDARY_VM_EXEC_CONTROL, exec_ctrl);
+}

The second argument is always true.

No...

There are 3 places calling this function with set=false：
nested_release_vmcs12(), vmx_disable_pml() and
vmx_cpuid_update()

Do you have any plans for it?

Should we instead add functions like vmcs_or32 and vmcs_clear32?

Sounds good to me, will do it.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html