Joerg Roedel <[email protected]> writes: > On Mon, Oct 05, 2015 at 12:54:43PM -0400, Bandan Das wrote: >> Joerg Roedel <[email protected]> writes: >> The problems is that the next_rip field could be stale. If the processor >> supports >> next_rip, then it will clear it out on the next entry. If it doesn't, >> an old value just sits there (no matter who wrote it) and the problem >> happens when skip_emulated_instruction advances the rip with an incorrect >> value. > > So the right fix would be to just set the guests next_rip to 0 when we > emulate vmrun, just like real hardware does, no?
Agreed, resetting to 0 if nrips isn't supported seems right. It would still help having a printk_once in this case IMO :) > > Joerg > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
