On 11/19/2015 08:59 AM, Takuya Yoshikawa wrote:
On 2015/11/18 11:44, Xiao Guangrong wrote:

On 11/12/2015 07:50 PM, Takuya Yoshikawa wrote:
+            if (!ret) {
+                clear_unsync_child_bit(sp, i);
+                continue;
+            } else if (ret > 0) {
                  nr_unsync_leaf += ret;

Just a single line here, braces are unnecessary.

-            else
+            } else
                  return ret;

I know we can eliminate the braces, but that does not mean
we should do so: there seems to be no consensus about this
style issue and checkpatch accepts both ways.

Actually, some people prefer to put braces when one of the
if/else-if/else cases has multiple lines.  You can see
some examples in kernel/sched/core.c: see hrtick_start(),
sched_fork(), free_sched_domain().

In our case, I thought putting braces would align the else-if
and else and make the code look a bit nicer, but I know this
may be just a matter of personal feeling.

In short, unless the maintainer, Paolo for this file, has any
preference, both ways will be accepted.

The reason why i pointed this out is that it is the style documented
in Documentation/CodingStyle:
| Do not unnecessarily use braces where a single statement will do.
|        if (condition)
|                action();

Actually, Ingo Molnar hated this braces-style too much and blamed
many developers who used this style (include me, that why i was
nervous to see this style :( ).

If this style is commonly accepted now, it is worth making a patch
to update Documentation/CodingStyle.

To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to