On Fri, Dec 18, 2015 at 11:42:40AM +0100, Radim Krčmář wrote: > 2015-12-17 12:45-0600, Andrew Jones: > > On Thu, Dec 17, 2015 at 06:53:32PM +0100, Radim Krčmář wrote: > >> We'll be using it from scripts/mkstandalone later. > >> > >> Signed-off-by: Radim Krčmář <rkrc...@redhat.com> > >> --- > >> v2: new > >> > >> run_tests.sh | 53 > >> +---------------------------------------------------- > >> scripts/run.bash | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > > > Could probably just put run() in scripts/functions.bash > > Definitely. The drawback is that for_each_unittest() and any future > helper would be pasted in each unit test, which would complicate > conversion back to shell and uselessly bloat tests. Even though I like
Oh right, nevermind then. If we're going to 'cat run.bash >>' then it needs to be separate. But do we really want to 'cat run.bash'? I guess I need to look at your mkstandalone changes again. > programming in shell far more than in C, I would not do it if we decide > to POSIX our standalone tests. (Bloating is not an issue for me.) > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
