David Huff wrote:
looking for comments/feedback....

These relatively simple changes to kvm_runtest_2 will allow for the addition of new tests without having modifying kvm_runtest "code."
One would just add a newtest.py file and update the config file.  This will 
simplify test development and make it easier to deploying new tests in an 
existing environment.

The patch looks for tests that are not statically defined in kvm_runtest_2.py in 
./kvm-autotest/client/tests/kvm_runtest_2/kvm_tests/'testname'.py and dynamically loads a 
module with a corresponding method run_'testname' where testname is defined by the 
"type" parameter in the config file.


Hi David,

I'm not sure this patch-set makes development much easier, as it only saves adding one line (entry) in test_routines table, but is less flexible (e.g. force file-name and function-name of test routines).

Moving the test to a separate kvm_tests directory can be done without dynamic load of the tests.

I don't have strong feelings about it though.

What others think ?

Thanks,
    Uri.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to