Avi Kivity wrote: > Glauber Costa wrote: >> This is a pretty mechanical change. To make code look >> closer to upstream qemu, I'm renaming kvm_context_t to >> KVMState. Mid term goal here is to start sharing code >> whereas possible. >> > > Doesn't apply. > > Also, it's a little fishy. We now have two KVMState types, but they're > pretty different. > > What we could do is embed a kvm_context_t variable in the real KVMState, > and start using that. Then, we could, function by function, use the > upstream KVMState functionality and remove the corresponding > kvm_context_t functionality.
That would be great and was also what I had vaguely in mind. Likely there are already fields that can be used from KVMState (fd and vmfd?). > >> Avi, please apply, or I'll send you a video of myself >> dancing naked. >> > > The list has a size limit, so don't attach a huge video. Post a URL > instead. > But only after 22:00 - in case underages are reading. Jan
signature.asc
Description: OpenPGP digital signature
