----- "Lucas Meneghel Rodrigues" <l...@redhat.com> wrote: > On Mon, 2009-06-08 at 04:48 -0400, Michael Goldish wrote: > > Hi Lucas, > > > > I'm bothering you with technicalities again unfortunately: > > > > 1. I'm not sure if it's customary to add @author tags to other > modules except the main kvm.py one, but in case it is, here's what I > think should be there (reflects the state of kvm_runtest_2 until > before the merge with Autotest): > > We opted to not put credits in all modules, so I chose the kvm class > docstring and the control file to put the list of authors, with the > exceptions of stepmaker, stepeditor and other stand alone programs.
OK, I didn't notice the tags appeared only in stand alone programs. BTW, stepmaker currently isn't a stand-alone program (it used to be and may be again in the future, but making it so is not high on our priority list). Also, scan_results.py and kvm_config.py are stand-alone programs but it seems they don't have the tags (at least in the most recent version of the tree that I've cloned -- I'm not sure it's up to date). > The kvm class docstring and the control files contain all the people > you've mentioned on the e-mail, and I put the authors of the stand > alone > programs, such as stepeditor and stepmaker, so hopefully everything > is > OK on this regard. > > I've never used the tag @credits. That said, IMHO authorship does > belong > more to the revision control system than the source files, although I > see value on putting authorship info in *some* of the source files. Makes sense. Thanks, Michael > > - For kvm_vm.py, kvm_utils.py, kvm_tests.py: > > Uri Lublin (u...@redhat.com) > > Dror Russo (dru...@redhat.com) > > Michael Goldish (mgold...@redhat.com) > > > > - For make_html_report.py: > > Dror Russo (dru...@redhat.com) > > (may already be there) > > > > - For scan_results.py, calc_md5sum_1m.py, fix_cdkeys.py: > > Uri Lublin (u...@redhat.com) > > > > - For kvm_install.py: > > Uri Lublin (u...@redhat.com) > > Dror Russo (dru...@redhat.com) > > Michael Goldish (mgold...@redhat.com) > > David Huff (dh...@redhat.com) > > Mike Burns (mbu...@redhat.com) > > > > - For kvm_guest_wizard.py: > > Alexey Eromenko (aerom...@redhat.com) > > Uri Lublin (u...@redhat.com) > > Dror Russo (dru...@redhat.com) > > Michael Goldish (mgold...@redhat.com) > > > > - For kvm_config.py, kvm_preprocessing.py, stepeditor.py, > stepmaker.py, ppm_utils.py: > > Michael Goldish (mgold...@redhat.com) > > > > I hope I didn't forget anything (or anyone). > > I also hope new authors will be added as more people contribute to > the project. > > > > 2. Now that many files were modified due to the merge I'm not sure > the above list is still valid -- you should probably be given credit, > but I'm not sure exactly what files you modified (all of them?). > > > > 3. Should we use @credits tags as well, or something similar? > > > > Thanks, > > Michael > > > > ----- Original Message ----- > > From: "Lucas Meneghel Rodrigues" <l...@redhat.com> > > To: autot...@test.kernel.org > > Cc: "KVM mailing list" <kvm@vger.kernel.org>, "Uri Lublin" > <u...@redhat.com> > > Sent: Monday, June 1, 2009 6:46:34 PM (GMT+0200) Auto-Detected > > Subject: Re: [PATCH] Fixing kvm test authorship issue > > > > Ok, patch applied. Thanks for pointing this out, Uri. > > > > On Mon, 2009-06-01 at 12:41 -0300, Lucas Meneghel Rodrigues wrote: > > > When preparing the kvm test for inclusion on autotest, I did > > > forget to add the name of Dror Russo (dru...@redhat.com) as > > > one of the rightful authors of the test. This patch includes > > > his name on the docstrings of the test. > > > --- > > > client/tests/kvm/control | 1 + > > > client/tests/kvm/kvm.py | 1 + > > > client/tests/kvm/make_html_report.py | 1 + > > > 3 files changed, 3 insertions(+), 0 deletions(-) > > > > > > diff --git a/client/tests/kvm/control b/client/tests/kvm/control > > > index f4b2113..eb38686 100644 > > > --- a/client/tests/kvm/control > > > +++ b/client/tests/kvm/control > > > @@ -1,5 +1,6 @@ > > > AUTHOR = """ > > > u...@redhat.com (Uri Lublin) > > > +dru...@redhat.com (Dror Russo) > > > mgold...@redhat.com (Michael Goldish) > > > dh...@redhat.com (David Huff) > > > aerom...@redhat.com (Alexey Eromenko) > > > diff --git a/client/tests/kvm/kvm.py b/client/tests/kvm/kvm.py > > > index 91ec89a..1b9013c 100644 > > > --- a/client/tests/kvm/kvm.py > > > +++ b/client/tests/kvm/kvm.py > > > @@ -17,6 +17,7 @@ class kvm(test.test): > > > > > > @copyright: Red Hat 2008-2009 > > > @author: Uri Lublin (u...@redhat.com) > > > + @author: Dror Russo (dru...@redhat.com) > > > @author: Michael Goldish (mgold...@redhat.com) > > > @author: David Huff (dh...@redhat.com) > > > @author: Alexey Eromenko (aerom...@redhat.com) > > > diff --git a/client/tests/kvm/make_html_report.py > b/client/tests/kvm/make_html_report.py > > > index 988b2f3..6aed39e 100755 > > > --- a/client/tests/kvm/make_html_report.py > > > +++ b/client/tests/kvm/make_html_report.py > > > @@ -4,6 +4,7 @@ Script used to parse the test results and generate > an HTML report. > > > > > > @copyright: (c)2005-2007 Matt Kruse (javascripttoolbox.com) > > > @copyright: Red Hat 2008-2009 > > > +...@author: Dror Russo (dru...@redhat.com) > > > """ > > > > > > import os, sys, re, getopt, time, datetime, commands > -- > Lucas Meneghel Rodrigues > Software Engineer (QE) > Red Hat - Emerging Technologies -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
