Re: KVM: protect concurrent make_all_cpus_request

[Avi Kivity]

On 06/17/2009 04:53 PM, Marcelo Tosatti wrote:

make_all_cpus_request contains a race condition which can
trigger false request completed status, as follows:

CPU0                                              CPU1

if (test_and_set_bit(req,&vcpu->requests))
    ....                                                   if 
(test_and_set_bit(req,&vcpu->requests))
    ..                                                  return
proceed to smp_call_function_many(wait=1)

Use a spinlock to serialize concurrent CPUs.

Applied, thanks.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html