Gleb Natapov <g...@redhat.com> wrote on 19/10/2009 14:59:53:
> From: > > Gleb Natapov <g...@redhat.com> > > To: > > Orit Wasserman/Haifa/i...@ibmil > > Cc: > > kvm@vger.kernel.org, Ben-Ami Yassour1/Haifa/i...@ibmil, Abel Gordon/ > Haifa/i...@ibmil, Muli Ben-Yehuda/Haifa/i...@ibmil, > aligu...@us.ibm.com, md...@us.ibm.com > > Date: > > 19/10/2009 15:00 > > Subject: > > Re: [PATCH 3/5] Nested VMX patch 3 implements vmptrld and vmptrst > > On Thu, Oct 15, 2009 at 04:41:44PM +0200, or...@il.ibm.com wrote: > > +static struct page *nested_get_page(struct kvm_vcpu *vcpu, > > + u64 vmcs_addr) > > +{ > > + struct page *vmcs_page = NULL; > > + > > + down_read(¤t->mm->mmap_sem); > > + vmcs_page = gfn_to_page(vcpu->kvm, vmcs_addr >> PAGE_SHIFT); > > + up_read(¤t->mm->mmap_sem); > Why are you taking mmap_sem here? gup_fast() takes it if required. I will remove it. > > > + > > + if (is_error_page(vmcs_page)) { > > + printk(KERN_ERR "%s error allocating page \n", __func__); > > + kvm_release_page_clean(vmcs_page); > > + return NULL; > > + } > > + > > + return vmcs_page; > > + > > +} > > + > > -- > Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html