On 11/02/2009 04:22 AM, Ingo Molnar wrote:

* Gleb Natapov<g...@redhat.com>  wrote:

diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
index f4cee90..14707dc 100644
--- a/arch/x86/mm/fault.c
+++ b/arch/x86/mm/fault.c
@@ -952,6 +952,9 @@ do_page_fault(struct pt_regs *regs, unsigned long 
error_code)
        int write;
        int fault;

+       if (arch_handle_page_fault(regs, error_code))
+               return;
+

This patch is not acceptable unless it's done cleaner. Currently we
already have 3 callbacks in do_page_fault() (kmemcheck, mmiotrace,
notifier), and this adds a fourth one.

There's another alternative - add our own exception vector
for async page faults.  Not sure if that is warranted though,
especially if we already have other callbacks in do_page_fault()
and we can consolidate them.

--
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to