On Tue, Dec 15, 2009 at 11:14:07AM -0800, Shirley Ma wrote: > Hello Michael, > > On Tue, 2009-12-15 at 20:47 +0200, Michael S. Tsirkin wrote: > > > + detach_buf(vq, i); > > > + END_USE(vq); > > > + return vq->data[i]; > > > > In fact, this will return NULL always, won't it? > > Nope, I changed the destroy to detach and return the buffers without > destroying them within the call. I thought it might be useful in some > other case. > > Maybe I should put destroy call back? > > Thanks > Shirley
No I think it's good as is, we do not need a callback. I was simply saying that detach_buf sets data to NULL, so return vq->data[i] after detach does not make sense. You need to save data as comment below says.c -- MST -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
