On Thu, Mar 04, 2010 at 05:20:22PM +0100, Jan Kiszka wrote:
> Jan Kiszka wrote:
> > Glauber Costa wrote:
> >> This option deprecates --enable-kvm. It is a more flexible option,
> >> that makes use of qemu-opts, and allow us to pass on options to enable or
> >> disable kernel irqchip, for example.
> >>
> >
> > ...
> >
> >> diff --git a/qemu-options.hx b/qemu-options.hx
> >> index 3f49b44..f8fd86d 100644
> >> --- a/qemu-options.hx
> >> +++ b/qemu-options.hx
> >> @@ -1793,10 +1793,17 @@ Set the filename for the BIOS.
> >> ETEXI
> >>
> >> #ifdef CONFIG_KVM
> >> -DEF("enable-kvm", 0, QEMU_OPTION_enable_kvm, \
> >> - "-enable-kvm enable KVM full virtualization support\n")
> >> +HXCOMM Options deprecated by -kvm
> >> +DEF("enable-kvm", 0, QEMU_OPTION_enable_kvm, "")
> >> +
> >> +DEF("kvm", HAS_ARG, QEMU_OPTION_kvm, \
> >> + "-kvm enable=on|off,irqchip-in-kernel=on|off\n" \
> >> + " enable KVM full virtualization support\n")
> >> +
>
> Argh, never trust documentation: The magic option is "enabled", not
> "enable". :)
>
> >
> > I would prefer "irqchip=kernel|user" - shorter and even more verbose.
>
> And we should refuse to work if the user tries to enable in-kernel
> support without having io-threads enabled. That obviously fails silently
> so far.
>
> "info kvm" should also be extended to report the configuration in force.
I am waiting for marcelo to apply your patches (if he hasn't done already), then
I'll redo this. Agreed with this point, so plan on changing.
>
> >
> > Forgot if that was discussed already: Do we want "pit=kernel|user" as well?
> >
>
I guess we do.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
