----- "Lucas Meneghel Rodrigues" <[email protected]> wrote: > As it is hard to guarantee that a qcow2 image will be in a > consistent state with a VM turned on, take an extra safety > step and make sure the preprocessor shuts down the VMs > before the post process command check_image.py runs. > > Signed-off-by: Lucas Meneghel Rodrigues <[email protected]> > --- > client/tests/kvm/tests_base.cfg.sample | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/client/tests/kvm/tests_base.cfg.sample > b/client/tests/kvm/tests_base.cfg.sample > index 340b0c0..beae786 100644 > --- a/client/tests/kvm/tests_base.cfg.sample > +++ b/client/tests/kvm/tests_base.cfg.sample > @@ -1049,6 +1049,8 @@ variants: > post_command = " python scripts/check_image.py;" > remove_image = no > post_command_timeout = 600 > + kill_vm = yes > + kill_vm_gracefully = yes
That's not necessarily bad, but this may significantly slow down testing because it means the VM will shutdown and boot up again after every qcow2 test. It'll also separate the tests in an unnatural way, eliminating the possibility of catching problems that only appear after several consecutive tests (such problems may or may not be possible, I'm not sure). Maybe we should consider specifying the post_command for only some of the tests, or add a dedicated test for this purpose, or even a no-op test that only shuts down the VM and runs the post command. > - vmdk: > only Fedora Ubuntu Windows > only smp2 > -- > 1.6.6.1 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
