On Mon, Apr 19, 2010 at 02:10:54PM +0300, Avi Kivity wrote: > On 04/19/2010 02:05 PM, Peter Zijlstra wrote: > >> > >>>ACCESS_ONCE() is your friend. > >>> > >>I think it's implied with atomic64_read(). > >Yes it would be. I was merely trying to point out that > > > > last = ACCESS_ONCE(last_value); > > > >Is a narrower way of writing: > > > > last = last_value; > > barrier(); > > > >In that it need not clobber all memory locations and makes it instantly > >clear what we want the barrier for. > > Oh yes, just trying to avoid a patch with both atomic64_read() and > ACCESS_ONCE(). you're mixing the private version of the patch you saw with this one. there isn't any atomic reads in here. I'll use a barrier then
-- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
