On 06/16/2010 01:43 PM, Juan Quintela wrote:
Alex Williamson<[email protected]> wrote:
On Wed, 2010-06-16 at 17:47 +0200, Juan Quintela wrote:
Anthony Liguori<[email protected]> wrote:
On 06/14/2010 03:28 PM, Alex Williamson wrote:
PCI hotplug currently doesn't work after a migration because
we don't migrate the enable bits of the GPE state. Pull hotplug
structs into vmstate.
Signed-off-by: Alex Williamson<[email protected]>
Applied. Thanks.
Regards,
Anthony Liguori
I think this is better implemented as a subsection. We didin't need
this until hotplug arrived, I think that checking if any up/down are
!= 0 and then send it as subsections is a best way to do it.
This way it could also be backported to stable.
The slots aren't really the issue, they were mostly for completeness.
The key is gpe.en, which is likely always going to be all 1s for an ACPI
aware OS. So if we test != 0, we're going to need that subsection in
99% of the cases. Maybe we can assume gpe.en is all set on the target,
but I don't really look forward to finding out the ways that might
break. Thanks,
We have never sent it before. That means that the default value (for
whatever value is it) should be working quite well.
But it is not my call.
This sounds like a case where we're sending broken state so we need to
bump the version number. Subsections don't eliminate the need to bump
version numbers when we fundamentally screw up.
Regards,
Anthony Liguori
Later, Juan.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
